Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a release workflow #69

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Add a release workflow #69

merged 3 commits into from
Jan 25, 2024

Conversation

CasperWA
Copy link
Collaborator

Closes #68

It will update the changelog and the Python package version in init.py.

It will update the changelog and the Python package version in
__init__.py.
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f713bcc) 98.22% compared to head (2062774) 98.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files          14       14           
  Lines         508      508           
=======================================
  Hits          499      499           
  Misses          9        9           
Flag Coverage Δ
docker 97.63% <ø> (ø)
local 98.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

release:
name: External
uses: SINTEF/ci-cd/.github/workflows/cd_release.yml@v2.7.2
if: github.repository == 'SINTEF/dlite-entities-service' && startsWith(github.ref, 'refs/tags/v')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit hard for me to understand what this part is doing, I'm assuming it means if it starts with a 'version' tag? startsWith(github.ref, 'refs/tags/v')

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. tags have the git ref refs/tags/... branches have the git ref refs/heads/... or head... I don't remember. So essentially, we're just saying we only want the release workflow to run for tags that start with a v.

build_libs: flit
build_cmd: "flit build"
changelog_exclude_labels: skip_changelog,duplicate,question,invalid,wontfix
publish_on_pypi: false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a package that (currently) is published on PyPI.

publish_on_pypi: false

# Documentation
update_docs: false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no documentation in this repository for this package...

Copy link

@DanielMarchand DanielMarchand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my questions, though I think you can go ahead and merge.

@CasperWA CasperWA enabled auto-merge (squash) January 25, 2024 14:43
@CasperWA CasperWA disabled auto-merge January 25, 2024 14:43
@CasperWA CasperWA merged commit 22dae4f into main Jan 25, 2024
11 checks passed
@CasperWA CasperWA deleted the cwa/close-68-add-release-workflow branch January 25, 2024 14:46
Copy link

@daniel-sintef daniel-sintef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a release workflow
3 participants