-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a release workflow #69
Conversation
It will update the changelog and the Python package version in __init__.py.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
=======================================
Coverage 98.22% 98.22%
=======================================
Files 14 14
Lines 508 508
=======================================
Hits 499 499
Misses 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
release: | ||
name: External | ||
uses: SINTEF/ci-cd/.github/workflows/cd_release.yml@v2.7.2 | ||
if: github.repository == 'SINTEF/dlite-entities-service' && startsWith(github.ref, 'refs/tags/v') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit hard for me to understand what this part is doing, I'm assuming it means if it starts with a 'version' tag? startsWith(github.ref, 'refs/tags/v')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. tags have the git ref refs/tags/...
branches have the git ref refs/heads/...
or head
... I don't remember. So essentially, we're just saying we only want the release workflow to run for tags that start with a v
.
build_libs: flit | ||
build_cmd: "flit build" | ||
changelog_exclude_labels: skip_changelog,duplicate,question,invalid,wontfix | ||
publish_on_pypi: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a package that (currently) is published on PyPI.
publish_on_pypi: false | ||
|
||
# Documentation | ||
update_docs: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no documentation in this repository for this package...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my questions, though I think you can go ahead and merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
Closes #68
It will update the changelog and the Python package version in init.py.