Add --strict option to CLI
#132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 92.18% 92.26% +0.08%
==========================================
Files 26 26
Lines 1343 1357 +14
==========================================
+ Hits 1238 1252 +14
Misses 105 105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Added to validate and upload commands. Add tests for the new --strict option. Allow wrapping for summary columns (except name+version).
36b3a5e to
e013aee
Compare
5 tasks
Treesarj
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #129
Adds the
--strictflag option to the CLI commandsuploadandvalidate.This is centered around the
validatecommand. If--strictis supplied, if an entity already exists externally and differs in content, validation will fail for that entity.Therefore,
--strictis also mutually exclusive with--no-external-calls. If both are supplied an error will be raised.Note, this PR also updates the codecov-action to v4.