Fix using access token #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check is moved "up" in the code, to the block where an authorized call to the OpenID userinfo-endpoint failed, meaning the provided credentials were not valid as an OpenID. Previously this was done if the returned JSON-decoded response could not be validated as a `GitLabOpenIDUserInfo` model - something that is done after a (successful) response to the OpenID userinfo-endpoint.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
==========================================
+ Coverage 89.34% 89.84% +0.50%
==========================================
Files 21 21
Lines 1192 1192
==========================================
+ Hits 1065 1071 +6
+ Misses 127 121 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Treesarj
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112
This moves the call to
verify_user_access_token()"up" in theverify_token()function as well as tests that the function is invoked when expected.