-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.11, 3.12 and 3.13 #205
Conversation
Replace all ignored warnings with "error" to make all warnings errors.
This is validated only when the `ci-cd` package is installed and used, and is validated against the Python versions it supports.
Add pyupgrade as a pre-commit hook with --py37-plus arg. Run and upgrade all files accordingly. Configure mypy to check typing expecting Python 3.7.
Instead of using env vars as ${{ env.XXX }}, use them as ${XXX} if found in a bash "run" value segment.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
+ Coverage 79.95% 80.07% +0.11%
==========================================
Files 12 12
Lines 828 838 +10
==========================================
+ Hits 662 671 +9
- Misses 166 167 +1 ☔ View full report in Codecov by Sentry. |
This reverts commit 430c561.
Depending on the documentation framework, this ensures the minimum set of packages are installed for building the documentation.
Update pyupgrade hook accordingly.
…pport-implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a couple of questions; several about what seems to be historically non-tested code.
…pport-implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks a lot!
Validate python-version user inputs for callable workflows that installs and uses the local
ci-cd
package.Add pyupgrade as a pre-commit hook with the
--py37-plus
argument.Update configurations for pytest:
Update configurations for mypy: Use Python 3.7.
Note, this PR is labeled BLOCKING because a change in required status checks is required to merge this PR, leaving other PRs unable to succeed the list of required status checks until this has been merged.