Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CODECOV_TOKEN secret in CI #127

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Conversation

CasperWA
Copy link
Collaborator

Fixes #119

Use a secret token when uploading to Codecov.io. While this is not strictly necessary (public repository) it should help minimize the upload issues we are seeing a lot at the moment - and it doesn't hurt.

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #127 (343b92f) into main (13e8d9c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   65.67%   65.67%           
=======================================
  Files           9        9           
  Lines         472      472           
=======================================
  Hits          310      310           
  Misses        162      162           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@CasperWA CasperWA added priority/low Low priority issue/PR priority/high High priority issue/PR and removed priority/low Low priority issue/PR labels Mar 24, 2023
Copy link
Contributor

@daniel-sintef daniel-sintef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChatGPT: The change looks good and is necessary for proper integration with Codecov. It correctly uses the secrets context to access the CODECOV_TOKEN secret, ensuring that the token remains secure.

I recommend approving and merging this pull request.

@CasperWA CasperWA merged commit ab8d54f into main Mar 24, 2023
@CasperWA CasperWA deleted the cwa/fix-119-use-codecov-token branch March 24, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/high High priority issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use codecov upload token
2 participants