Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roth24 companions #556

Merged
merged 32 commits into from
Jan 7, 2025
Merged

Roth24 companions #556

merged 32 commits into from
Jan 7, 2025

Conversation

rothermichaustin
Copy link
Contributor

@rothermichaustin rothermichaustin commented Oct 1, 2024 •
edited
Loading

Ingest the companion relations for Roth24

Link to relevant issue: #547

For data

  • includes script used for ingest
  • includes modified JSON files
  • Add new tests
  • Update the Versions table

rothermichaustin and others added 25 commits March 8, 2024 11:17
@rothermichaustin
first commit
dab5afc
@rothermichaustin
start of ingest script
4eab56c
@rothermichaustin
Merge branch 'main' of github.com:SIMPLE-AstroDB/SIMPLE-db into Roth2…
e0fa464 
…4-sptypes
@Exu-112
refactor ingest_spectral_types function
d6adf75
@kelle
Merge branch 'main' into refactor_ingest_spectral_types_function
0371ac9
@kelle
trying to get tests to pass
ff07a4e
@kelle
getting tests to pass
bf379cc
@kelle
add photometric column, updating docs
64dbb2e
@kelle
refactor ingest_spectral_type function
a0898a6
@rothermichaustin
Merge branch 'refactor_ingest_spectral_types_function' of github.com:…
5e0c867 
…Exu-112/SIMPLE-db into Roth24-sptypes
@kelle
add raise_error keyword
ccd9140
@rothermichaustin
Merge branch 'refactor_ingest_spectral_types_function' of github.com:…
dd5ddaf 
…Exu-112/SIMPLE-db into Roth24-sptypes
@kelle
improve error handling
2f1d7ed
@kelle
error handling
570f0e3
@rothermichaustin
Merge branch 'refactor_ingest_spectral_types_function' of github.com:…
1104535 
…Exu-112/SIMPLE-db into Roth24-sptypes
@rothermichaustin
Updated working script and tests
680ac25
@kelle
Merge branch 'main' into Roth24-sptypes
34af275
@rothermichaustin
Extra prints commented out
406cb1c
@rothermichaustin
completed ingest script
5aad6ff
@rothermichaustin
JSON files and test
43080a0
@rothermichaustin
Deleted notebook
27099d1
@rothermichaustin
Updated Versions.json
9a2839f
@rothermichaustin
Fixed error in Versions.json
50507b8
@rothermichaustin
Merge branch 'main' of github.com:SIMPLE-AstroDB/SIMPLE-db into Roth2…
3c8ac75 
…4-companions
@rothermichaustin
adding script to ingest Roth24 companion relations
e57b773
@rothermichaustin rothermichaustin marked this pull request as draft October 1, 2024 19:02
@kelle
Copy link
Collaborator

kelle commented Oct 1, 2024

Currently stuck until we update astrodbkit and astrodb_utils to use astrodbkit.

@kelle
Copy link
Collaborator

kelle commented Oct 2, 2024

@rothermichaustin , the latest version of astrodb_utils is now published. Please pip install astrodb-utils --upgrade and try running your script again. You should have astrodbkit v1.0 and astrodb-utils v0.2.2. You can check that with this command: conda list | grep astrodb

@kelle
Copy link
Collaborator

kelle commented Oct 29, 2024

@rothermichaustin , please also include the new tests and the changes we made to the ingest_companion_relationships function. These files should be listed in VSCode under "Changes"

@rothermichaustin rothermichaustin marked this pull request as ready for review January 7, 2025 18:15
kelle
kelle approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@kelle kelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assume tests pass, this looks great!

@kelle kelle merged commit adb1d32 into SIMPLE-AstroDB:main Jan 7, 2025
4 checks passed
This was referenced Jan 7, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelle kelle kelle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rothermichaustin @kelle @Exu-112