Fixed max chunk size for landmark transmission from imk file #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rostest
approved these changes
Jun 13, 2024
|
Many thanks for your feedback and contribution! |
aiplemaSICKAG
pushed a commit
that referenced
this pull request
Jul 2, 2024
|
The pull request is merged in sick_scan_xd release 3.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix should solve a problem that it is not possible to transfer an IMK file to a NAV350 if it contains more than 50 landmarks.
According to the "Telegram listing" (page 55, see screenshot), a maximum of 50 landmarks can be transferred with one command.
The fix is to iterate over the landmarks and execute the "AddLandmark" command for chunks with a maximum of 50 landmarks.