Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: visitor with dataclass objects and tests #35

Merged
merged 6 commits into from
Nov 21, 2022
Merged

feat: visitor with dataclass objects and tests #35

merged 6 commits into from
Nov 21, 2022

Conversation

byung-o
Copy link
Collaborator

@byung-o byung-o commented Nov 15, 2022

No description provided.

@byung-o byung-o requested a review from mjspeck November 15, 2022 23:02
@byung-o byung-o self-assigned this Nov 15, 2022
mjspeck
mjspeck requested changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@mjspeck mjspeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the CHO object needs to change. Other than that this looks good.

src/daidepp/keywords.py Outdated Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
mjspeck
mjspeck approved these changes Nov 21, 2022
View reviewed changes
Copy link
Collaborator

@mjspeck mjspeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@byung-o byung-o merged commit 3e2918d into main Nov 21, 2022
@byung-o byung-o deleted the feature/enhanced-daidepp branch November 21, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjspeck mjspeck mjspeck approved these changes

Assignees

@byung-o byung-o

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byung-o @mjspeck