Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daide string generation and tests #31

Merged
merged 3 commits into from
Nov 9, 2022
Merged

daide string generation and tests #31

merged 3 commits into from
Nov 9, 2022

Conversation

byung-o
Copy link
Collaborator

@byung-o byung-o commented Nov 8, 2022

resolves #26

@byung-o byung-o requested a review from mjspeck November 8, 2022 22:06
@byung-o byung-o self-assigned this Nov 8, 2022
@byung-o byung-o linked an issue Nov 8, 2022 that may be closed by this pull request
Support DAIDE string construction from keyword tokens #26
Closed
mjspeck
mjspeck requested changes Nov 9, 2022
View reviewed changes
Copy link
Collaborator

@mjspeck mjspeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@byung-o could you add instructions on using this to the readme?

mjspeck
mjspeck requested changes Nov 9, 2022
View reviewed changes
Copy link
Collaborator

@mjspeck mjspeck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a couple of formatting changes when I ran black so you might need to run it on your end. If you did the changes could be due to a difference in configurations which we should address in another ticket. Aside from that, there are a couple of minor changes to make which I've listed in the comments. Once those are addressed this should be good to go.

P.S. since this is a pretty big change, bump the version in setup.cfg to 0.2.0. We can set up automatic versioning in the future.

src/daidepp/constants.py Outdated Show resolved Hide resolved
src/daidepp/keywords.py Outdated Show resolved Hide resolved
mjspeck
mjspeck approved these changes Nov 9, 2022
View reviewed changes
Copy link
Collaborator

@mjspeck mjspeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@byung-o byung-o merged commit 2fb710f into main Nov 9, 2022
@byung-o byung-o deleted the 26-support-daide-string-construction-from-keyword-tokens branch November 9, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjspeck mjspeck mjspeck approved these changes

Assignees

@byung-o byung-o

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support DAIDE string construction from keyword tokens
2 participants
@byung-o @mjspeck