Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean command not finding rimraf #71

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

shahednasser
Copy link
Collaborator

When I tried to run the build command in the monorepo, I got the following error:

medusa-plugin-strapi-ts: > medusa-plugin-strapi-ts@5.0.21 clean
medusa-plugin-strapi-ts: > ./node_modules/.bin/rimraf dist/ types/ services/ models/ migrations/ api/ subscribers/ utils/ index.js index.map.js
medusa-plugin-strapi-ts: sh: ./node_modules/.bin/rimraf: No such file or directory

That's because rimraf was installed in the root of the monorepo rather than in the medusa-plugin-strapi-ts package.

By changing the command to use npx, the path to rimraf will be inferred without having to guess where it's located.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for calling this out. Its people like you who keep the FOSS movement going.

@SGFGOV
Copy link
Owner

SGFGOV commented Jan 24, 2024

@shahednasser can you please rebase on to the development branch

@shahednasser shahednasser changed the base branch from master to development January 24, 2024 08:07
@shahednasser
Copy link
Collaborator Author

@SGFGOV done!

@SGFGOV
Copy link
Owner

SGFGOV commented Jan 24, 2024

@shahednasser thank you. Will you be able to fix the integration test also? There seems to be some issue building the tests

@shahednasser
Copy link
Collaborator Author

@SGFGOV I can't seem to reproduce the issue locally. I tried changing node versions, yarn versions, nothing happened.

Can you specify a possible solution? This doesn't seem to be related to the original issue that the PR addresses

@SGFGOV SGFGOV merged commit d7ba8b3 into SGFGOV:development Jan 27, 2024
16 of 17 checks passed
SGFGOV added a commit that referenced this pull request Jan 28, 2024
Co-authored-by: Shahed Nasser <shahednasser@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants