Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/strapi filters #37

Merged
merged 13 commits into from
Aug 23, 2023
Merged

Feat/strapi filters #37

merged 13 commits into from
Aug 23, 2023

Conversation

SGFGOV
Copy link
Owner

@SGFGOV SGFGOV commented Aug 23, 2023

No description provided.

Comment on lines 1984 to 1996
'Error occur while sending request to strapi: ' +
JSON.stringify({
'error.message': theError,
request: {
url: endPoint || 'none',
data: JSON.stringify(data) || 'none',
method: method || 'none',
},
response: {
body: JSON.stringify(responseData),
status: error?.response?.status ?? 'none',
},
})

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This logs sensitive data returned by [an access to password](1) as clear text. This logs sensitive data returned by [an access to password](2) as clear text.
};
const encoded = jwt.sign(strapiSignal, "test_secret");
const encoded = jwt.sign(strapiSignal, 'test_secret');

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "test_secret" is used as [key](1).
Copy link
Owner Author

@SGFGOV SGFGOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acceptable

@SGFGOV SGFGOV merged commit 38e2c17 into master Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant