Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper support for sRGB #222

Closed
eXpl0it3r opened this issue Dec 25, 2022 · 0 comments · Fixed by #252
Closed

Add proper support for sRGB #222

eXpl0it3r opened this issue Dec 25, 2022 · 0 comments · Fixed by #252
Labels
Feature New functionality or extending of an existing one
Milestone
2.6.0

Comments

@eXpl0it3r
Copy link
Member

Due to the way the CSFML API was implemented for creating/loading textures, there was no way to create textures in sRGB mode and the exposed setSrgb method was essentially useless.

With SFML/CSFML#177 this was fixed, which then however leaves a gap in SFML.NET. The property for sRGB needs to be adapted and the new creation functions need to be called from SFML.NET.
@eXpl0it3r eXpl0it3r added the Feature New functionality or extending of an existing one label Dec 25, 2022
DemoXinMC added a commit to DemoXinMC/SFML.Net that referenced this issue Jan 3, 2024
@DemoXinMC
Update Texture for CSFML's sRGB Support
740dbe0 
Addresses SFML#222
* Updated Texture's constructors with an optional parameter named "sRGB" which selects between the sRGB and non-sRGB versions of sfTexture_create*
* Allows Texture(byte[]) to specify a portion of the passed bytes to use for the new Texture, consistent with other existing constructors
This was referenced Jan 3, 2024
Closed
Closed
@eXpl0it3r eXpl0it3r mentioned this issue May 23, 2024
Closed
22 tasks
@Marioalexsan Marioalexsan mentioned this issue May 27, 2024
Merged
@eXpl0it3r eXpl0it3r added this to the 2.6.0 milestone Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature New functionality or extending of an existing one
Projects
None yet
Milestone
2.6.0
Development

Successfully merging a pull request may close this issue.

Update sRGB API for Texture and RenderTarget Marioalexsan/SFML.Net
1 participant
@eXpl0it3r