Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

navbar #80

Merged
merged 9 commits into from
Apr 2, 2024
Merged

navbar #80

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
641177e
navbar
JibrilExe Mar 11, 2024
b474f58
changes
JibrilExe Mar 12, 2024
6d1e576
oops
JibrilExe Mar 12, 2024
fb3dfa0
close bar on redirect
JibrilExe Mar 12, 2024
5ffca16
linter conflicts for component function
JibrilExe Mar 12, 2024
db1401f
merge en isloggedin
JibrilExe Mar 31, 2024
12a580e
scalability matters
JibrilExe Mar 31, 2024
fd2142a
useEffect to check login state and adjust link item list
JibrilExe Apr 1, 2024
fedfad7
a little more readable
JibrilExe Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions frontend/src/components/Header/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,16 @@ export function Header(): JSX.Element {
const location = useLocation();
const [open, setOpen] = useState(false);

const listItems = [
{link: "/", text: t("homepage")},
{link: "/projects", text: t("myProjects")},
{link: "/courses", text: t("myCourses")}
]
let listItems = [
{link: "/", text: t("homepage")}
];

if(isLoggedIn()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrap this in an effect. Everything that's not in an effect will be executed unnecessarily on every state change or mount

listItems = listItems.concat([
{link: "/projects", text: t("myProjects")},
{link: "/courses", text: t("myCourses")}
]);
}

const title = getTitle(location.pathname, t);

Expand All @@ -35,7 +40,7 @@ export function Header(): JSX.Element {
<Button color="inherit">{t('login')}</Button>
</Toolbar>
</AppBar>
<DrawerMenu open={open} onClose={() => setOpen(false)} listItems={isLoggedIn() ? listItems : [listItems[0]]}/>
<DrawerMenu open={open} onClose={() => setOpen(false)} listItems={listItems}/>
</Box>
);
}
Expand Down