This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Enhancement/projects file upload #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AronBuzogany
suggested changes
Mar 11, 2024
|
|
||
| file.save(file_location + "/" + filename) | ||
| try: | ||
| with zipfile.ZipFile(file_location + "/" + filename) as upload_zip: |
|
|
||
| file_location = os.path.join(project_upload_directory) | ||
|
|
||
| if not os.path.exists(project_upload_directory): |
There was a problem hiding this comment.
Just use, exist_ok=True without the if :)
|
|
||
| project_upload_directory = os.path.join(f"{UPLOAD_FOLDER}", f"{new_project.project_id}") | ||
|
|
||
| file_location = os.path.join(project_upload_directory) |
There was a problem hiding this comment.
path.join with 1 argument has no effect, did you forget second argument?
|
|
||
| # save the file that is given with the request | ||
|
|
||
| new_project = create_model_instance( |
There was a problem hiding this comment.
You don't handle the case where this fails
There was a problem hiding this comment.
The only thing that fails is me 😄
backend/project/utils/query_agent.py
Outdated
| db.session.commit() | ||
| return jsonify({ | ||
| "data": new_instance, | ||
| new_instance = create_model_instance(model, data, response_url_base, required_fields) |
There was a problem hiding this comment.
use model_instance, status_code = create_model_instance instead
backend/project/utils/query_agent.py
Outdated
| f"{response_url_base}/", | ||
| str(getattr(new_instance, url_id_field)))}), 201 | ||
| "url": | ||
| urljoin(response_url_base + "/", |
AronBuzogany
suggested changes
Mar 12, 2024
|
|
||
| # save the file that is given with the request | ||
|
|
||
| new_project, status_code = create_model_instance( |
There was a problem hiding this comment.
Still not doing anything about if it fails.
AronBuzogany
approved these changes
Mar 12, 2024
Vucis
approved these changes
Mar 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create functionality of file uploading when using POST to projects