Skip to content
This repository has been archived by the owner on Oct 21, 2023. It is now read-only.

Cannot join two imported values #72

Closed
indented-automation opened this issue Mar 9, 2020 · 0 comments
Closed

Cannot join two imported values #72

indented-automation opened this issue Mar 9, 2020 · 0 comments
Assignees
Labels

Comments

@indented-automation
Copy link
Collaborator

Description

Add-FnJoin fails when an Import value is used.

Support for Fn:ImportValue is described here:

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-join.html

Steps to reproduce

Add-FnJoin -Delimiter ',' -ListOfValues @(
    Add-FnImportValue -ValueToImport 'someValue1'
    Add-FnImportValue -ValueToImport 'someValue2'
)

Expected behaviour

Creation of a Join function call encapsulating the two import function calls.

Actual behaviour

Add-FnJoin: This parameter only accepts the following types: Vaporshell.Condition.If, Vaporshell.Function.Base64, Vaporshell.Function.FindInMap, Vaporshell.Function.GetAtt, Vaporshell.Function.GetAZs, Vaporshell.Function.Join, Vaporshell.Function.Select, Vaporshell.Function.Split, Vaporshell.Function.Ref, System.String. The current types of the value are: Vaporshell.Function.ImportValue, Vaporshell.Function, System.Management.Automation.PSCustomObject, System.Object.
scrthq added a commit that referenced this issue Mar 9, 2020
## 2.11.1 - 2020-03-09

* [Issue #72](#72)
  * Updated allowable types for `Add-FnJoin` to match current AWS documentation (was missing `Fn::ImportValue` and `Fn::Sub` support)
@scrthq scrthq self-assigned this Mar 9, 2020
@scrthq scrthq added the bug label Mar 9, 2020
@scrthq scrthq closed this as completed in 0672747 Mar 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants