-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(inquirer): Allow string choices (backward compat with v9 & prior) #1530
Conversation
I saw later that there is backward compatibility in place: Inquirer.js/packages/inquirer/src/ui/prompt.mts Lines 297 to 306 in ce5d3b6
It's possible to add to backward compatibility types only: Inquirer.js/packages/inquirer/src/types.mts Lines 50 to 57 in 9b77c67
Of course if the string support is added to choices, the backward compatibility can be dropped. |
Ohh I forgot about that. I'll still bring it over to |
2399af2
to
c56c54b
Compare
Ref #1527
Inquirer v9 & prior allowed choices to be array of strings. Given how widespread that pattern is, we should maintain this backward compatibility. It'll also simplify the work of folks migrating from
inquirer
to@inquirer/prompts
with less code change.TODO