Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in argument to patching auto skip #128

Closed
kaczmarj opened this issue Jun 11, 2023 · 0 comments · Fixed by #130
Closed

bug in argument to patching auto skip #128

kaczmarj opened this issue Jun 11, 2023 · 0 comments · Fixed by #130

Comments

@kaczmarj
Copy link
Member

command-line should be changed to a flag --auto-skip or --no-auto-skip. and the call stack should be modified accoringly.

wsinfer/wsinfer/_patchlib/create_patches_fp.py

Line 455 in a6e4d41

auto_skip=no_auto_skip,

kaczmarj added a commit that referenced this issue Jun 11, 2023
@kaczmarj
fix issue #128
1ee1852
kaczmarj added a commit that referenced this issue Jun 11, 2023
@kaczmarj
fix #128 and fix #129
8d69f1a
@kaczmarj kaczmarj mentioned this issue Jun 11, 2023
Merged
kaczmarj added a commit that referenced this issue Jun 12, 2023
@kaczmarj
fix auto-skip bug and gracefully handle failed patching (#130)
f7f1dc7 
* fix issue #128

* fix #128 and fix #129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix auto-skip bug and gracefully handle failed patching SBU-BMI/wsinfer
1 participant
@kaczmarj