fix(ui5-menu): adjust loading sub-menu #9423

unazko · 2024-07-09T12:32:41Z

Fixes: #7391

packages/main/src/Menu.ts

fix(ui5-menu): adjust sub-menu loading

80ce472

unazko requested a review from tsanislavgatev July 9, 2024 13:12

unazko marked this pull request as ready for review July 9, 2024 13:16

unazko added 6 commits July 12, 2024 18:31

fix: adjust menu item and sub-menu references

c46edf5

fix: remove redundant private property

b243b33

fix: console error on focus in

2ad38da

fix: adjust focus handler over loaded items

e043c5c

fix: adjust mobile view loading interactions

f925767

fix: create only a single sub-menu per menu item

b804d97

unazko added bug This issue is a bug in the code 1.24 labels Jul 15, 2024

unazko added this to the 1.24.8 milestone Jul 15, 2024

unazko self-assigned this Jul 15, 2024

unazko added bug This issue is a bug in the code and removed bug This issue is a bug in the code labels Jul 15, 2024

tsanislavgatev requested changes Jul 19, 2024

View reviewed changes

fix: resolve review comments

5ad05b1

unazko requested a review from tsanislavgatev July 19, 2024 13:19

tsanislavgatev approved these changes Jul 19, 2024

View reviewed changes

unazko requested a review from nnaydenow July 22, 2024 07:15

ilhan007 approved these changes Jul 29, 2024

View reviewed changes

unazko merged commit e47d1ea into SAP:release-1.24 Jul 29, 2024
9 checks passed

ilhan007 added downport and removed downport bug This issue is a bug in the code labels Aug 2, 2024

Provide feedback