Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui5-title): wrap text by default #8916

Merged
merged 3 commits into from
May 9, 2024
Merged

refactor(ui5-title): wrap text by default #8916

merged 3 commits into from
May 9, 2024
+61 −37

Conversation

dimovpetar
Copy link
Contributor

@dimovpetar dimovpetar commented May 8, 2024 •
edited
Loading

The text of ui5-title now wraps by default.

BREAKING CHANGE: wrapping-type property default value has changed from None to Normal.
Before:

<ui5-title>some very very very long title</ui5-title> <!-- would truncate the text if there is not enough space -->

Now:

<ui5-title>some very very very long title</ui5-title> <!-- would let the text wrap if there is not enough space -->

Related to #8461

ilhan007
ilhan007 reviewed May 8, 2024
View reviewed changes
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also remove these

Screenshot 2024-05-08 at 21 04 18

@ilhan007 ilhan007 merged commit f267f50 into main May 9, 2024
10 checks passed
@ilhan007 ilhan007 deleted the title_default_wrapping branch May 9, 2024 14:04
@dimovpetar dimovpetar mentioned this pull request May 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

Assignees
No one assigned
Labels
2.0 BREAKING CHANGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimovpetar @ilhan007