Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui5-li, ui5-list): changes accessibleRole type #8825

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

yanaminkova
Copy link
Member

@yanaminkova yanaminkova commented Apr 23, 2024

Changes the type of accessibleRole property for both ui5-li and ui5-list.

BREAKING CHANGE: The accessibleRole property for both ui5-li and ui5-list has been updated from a string type to an enum type.
Additionally, the new enums ListItemAccessibleRole and ListAccessibleRole have been introduced for these properties respectively.
The available options for the ui5-li:
ListItem- Represents the ARIA role "listitem". (by default)
MenuItem - Represents the ARIA role "menuitem".
TreeItem - Represents the ARIA role "treeitem".
Option - Represents the ARIA role "option".
None - Represents the ARIA role "none".

The available options for the ui5-list:
List- Represents the ARIA role "list". (by default)
Menu - Represents the ARIA role "menu".
Tree - Represents the ARIA role "tree".
ListBox - Represents the ARIA role "listbox".
If you have previously used:

<ui5-li accessible-role="menuitem"> List Item</ui5-li>
<ui5-list accessible-role="tree"> List </ui5-list>

Now use:

<ui5-li accessible-role="MenuItem"> List Item</ui5-li>
<ui5-list accessible-role="Tree"> List </ui5-list>

Related to #8461, #7887

Copy link
Contributor

@nnaydenow nnaydenow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems related to: #8810 . Lets wait until the other task is completed

Update: Ignore this comment

packages/main/src/ListItem.ts Outdated Show resolved Hide resolved
packages/main/src/List.ts Outdated Show resolved Hide resolved
@yanaminkova yanaminkova requested a review from nnaydenow April 25, 2024 07:34
packages/main/src/ListItem.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@nnaydenow nnaydenow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanaminkova yanaminkova merged commit 8235159 into main Apr 30, 2024
9 checks passed
@yanaminkova yanaminkova deleted the list-accrole2.0 branch April 30, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants