Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui5-li): removes role property #8814

Merged
merged 2 commits into from
Apr 23, 2024
Merged

refactor(ui5-li): removes role property #8814

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92021b2
refactor(ui5-li): removes role property
yanaminkova Apr 22, 2024
d73f051
refactor(ui5-li): removes role property
yanaminkova Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions packages/main/src/ListItem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,16 +186,6 @@ abstract class ListItem extends ListItemBase {
@property({ type: Boolean })
actionable!: boolean;

/**
* Used to define the role of the list item.
* @private
* @default "listitem"
* @since 1.0.0-rc.9
*
*/
@property({ defaultValue: "listitem" })
role!: string;

/**
* Defines the description for the accessible role of the component.
* @protected
Expand Down Expand Up @@ -513,7 +503,7 @@ abstract class ListItem extends ListItemBase {

get _accInfo(): AccInfo {
return {
role: this.accessibleRole || this.role,
role: this.accessibleRole,
ariaExpanded: undefined,
ariaLevel: undefined,
ariaLabel: ListItem.i18nBundle.getText(ARIA_LABEL_LIST_ITEM_CHECKBOX),
Expand Down