Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui5-menu): rename the busy and busy delay properties #8778

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

unazko
Copy link
Contributor

@unazko unazko commented Apr 16, 2024

Renames the busy and busyDelay properties of the ui5-menu and ui5-menu-item to loading and loadingDelay.

BREAKING CHANGE: The busy and busyDelay and properties of the ui5-menu and ui5-menu-item are renamed.
If you have previously used the busy, busyDelay properties:

<ui5-menu header-text="My ui5-menu" busy busy-delay="100"><ui5-menu>
<ui5-menu-item text="Open" icon="open-folder" busy busy-delay="100"><ui5-menu-item>

now you should use loading and loadingDelay properties:

<ui5-menu header-text="My ui5-menu" loading loading-delay="100"><ui5-menu>
<ui5-menu-item text="Open" icon="open-folder" loading loading-delay="100"><ui5-menu-item>

Fixes: #8764

@unazko unazko marked this pull request as ready for review April 19, 2024 07:34
@unazko unazko merged commit 3a4be3a into SAP:main Apr 22, 2024
9 checks passed
@unazko unazko mentioned this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui5-menu: runtime error
3 participants