Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui5-upload-collection): remove Delete selection mode #8607

Merged
merged 4 commits into from
Apr 8, 2024
Merged

refactor(ui5-upload-collection): remove Delete selection mode #8607

merged 4 commits into from
Apr 8, 2024

Conversation

dimovpetar
Copy link
Contributor

Removes the "Delete" option of selectionMode of ui5-upload-collection. So far this property didn't have any effect.

BREAKING CHANGE: The selectionMode property no longer accepts "Delete" as value.
If you have previously used it:

<ui5-upload-collection selection-mode="Delete"></ui5-upload-collection>

Now omit it completely:

<ui5-upload-collection></ui5-upload-collection>

Related to #8461

@dimovpetar dimovpetar marked this pull request as draft April 2, 2024 15:21
@dimovpetar dimovpetar mentioned this pull request Apr 2, 2024
Closed
@ilhan007 ilhan007 changed the base branch from release-2.0 to main April 4, 2024 21:07
@dimovpetar dimovpetar marked this pull request as ready for review April 8, 2024 13:25
@dimovpetar dimovpetar requested review from a team and ilhan007 April 8, 2024 14:50
@ilhan007 ilhan007 merged commit 926ae75 into main Apr 8, 2024
9 checks passed
@ilhan007 ilhan007 deleted the uc_selection_mode branch April 8, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 Awaiting requested review from ilhan007

Assignees
No one assigned
Labels
2.0 BREAKING CHANGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimovpetar @ilhan007