-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] serveIndex: use serve-index for serving the application index #253
Conversation
- using https://www.npmjs.com/package/serve-index for serving index files - Index is now more user-friendly - implements possibility for @ui5/cli to show hidden files and choose a view (tiles or details)
- date checking fails because of different formatting
Hey @jkoenig134, thank you for this PR! 🙌 Since serve-index is licensed under MIT, we need to include the license and properly attribute the code to the serve-index project. We'll do both in a follow up PR since we might need to do some minor refactoring to better separate the original serve-index code from ours. |
For future reference, a related PR: expressjs/serve-index#67 |
Hey @RandomByte, thank you very much for approval and merging! |
Cool, looking forward to it! Just to let you know, in #254 we swapped the API from Are you thinking of exposing these options as CLI parameters? |
@RandomByte the options are beeing exposed in my new pull request for @ui5/server, upcoming in the next minutes. I TOTALLY forgot this in the last PR... |
The directory listing of the UI5 Server has been overhauled by integrating parts of the serve-index[1] project (see [2]). The '--simple-index' flag allows to toggle between a detailed- and a simplified rendering of the directory index. Thanks to @jkoenig134 for this contribution! [1] https://github.com/expressjs/serve-index [2] SAP/ui5-server#253
The directory listing of the UI5 Server has been overhauled by integrating parts of the serve-index[1] project (see [2]). The '--simple-index' flag allows to toggle between a detailed- and a simplified rendering of the directory index. Thanks to @jkoenig134 for this contribution! [1] https://github.com/expressjs/serve-index [2] SAP/ui5-server#253
Released as part of UI5 CLI |
🎉🎉🎉🎉 |
i have talented colleagues, yeah |
My changes
createMiddleware has now therefore 3 arguments (the new one are optional -> no beaking changes
createMiddleware({resources, tiles, showHidden})
boolean
declares if the ui should show tiles or a detailed tableboolean
declares if dot files should be hidden or notPull Request Checklist