refactor: Improve caching of shared type files #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caching the script snapshot instances further improves the performance when re-using a shared service instance.
abd839c to
e6d4b35
Compare
- Don't include irrelevant types in the type loading process - Ensure that modules from sap.ui.core are not looked up within the linted project. This happened as there was no mapping for the sap/ui/core namespace and TypeScript first tried to load the module relative to the requesting module and only afterwards used the dts file from "types".
e6d4b35 to
55fad6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caching the script snapshot instances further improves the performance
when re-using a shared service instance.