Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTERNAL] Build: Add 'jsdoc' command #162

Merged
merged 1 commit into from
Mar 12, 2019
Merged

[INTERNAL] Build: Add 'jsdoc' command #162

merged 1 commit into from
Mar 12, 2019

Conversation

RandomByte
Copy link
Member

Depends on SAP/ui5-builder#42

@RandomByte RandomByte mentioned this pull request Mar 11, 2019
Merged
@coveralls
Copy link

coveralls commented Mar 11, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 82.051% when pulling 66f07f6 on add-jsdoc-build-cmd into 3745f39 on master.

svbender
svbender previously approved these changes Mar 11, 2019
View reviewed changes
devtomtom
devtomtom previously approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@devtomtom devtomtom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@RandomByte RandomByte dismissed stale reviews from devtomtom and svbender via 66f07f6 March 11, 2019 14:34
@RandomByte RandomByte force-pushed the add-jsdoc-build-cmd branch from 42ca88a to 66f07f6 Compare March 11, 2019 14:34
@RandomByte
Copy link
Member Author

RandomByte commented Mar 11, 2019 •
edited
Loading

Renamed commit: [INTERNAL] to [FEATURE]

@RandomByte RandomByte merged commit 3a2f4a1 into master Mar 12, 2019
@RandomByte RandomByte deleted the add-jsdoc-build-cmd branch March 12, 2019 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devtomtom devtomtom devtomtom approved these changes

@svbender svbender svbender left review comments

@matz3 matz3 Awaiting requested review from matz3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RandomByte @coveralls @devtomtom @svbender