[FIX] Don't report a missing module that's contained in another bundle #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matz3
reviewed
Jul 10, 2023
RandomByte
reviewed
Jul 11, 2023
lib/lbt/bundle/Resolver.js
Outdated
| @@ -51,6 +51,16 @@ class BundleResolver { | |||
| let selectedResources = Object.create(null); | |||
| let selectedResourcesSequence = []; | |||
| const pool = this.pool; | |||
| /** | |||
| * Names of modules that are required in some waym but could not be found | |||
There was a problem hiding this comment.
Suggested change
| * Names of modules that are required in some waym but could not be found | |
| * Names of modules that are required in some way but could not be found |
RandomByte
approved these changes
Jul 11, 2023
matz3
approved these changes
Jul 11, 2023
|
Merging this PR even with the failing tests as they are known false-positives. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.