-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] bundle/Builder: Support async require sections and conditional core boot #1020
Conversation
0314e80
to
74ff4ab
Compare
af1d63a
to
a673874
Compare
LGTM, but would be great if @codeworrior could take a brief look at the LBT changes |
11ea0fe
to
e2168a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generateStandaloneAppBundle
does not provide the UI5 version to the bundler, I guess because the config should be under our control. But in the intermediate state of this Pr, this might cause the generation of a self-contained bundle for UI5 2.0 with a sync require. Just mentioning it.
The UI5 version does not determine whether a sync- or async require is generated. This is rather define by the bundle configuration. Currently, the self-contained build does not explicitly set ui5-builder/lib/tasks/bundlers/generateStandaloneAppBundle.js Lines 52 to 57 in 58e37c0
|
99432ce
to
6778414
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (I can't approve)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version needs to be also passed in generateStandaloneAppBundle
task
5ee5d4a
to
52d8a5a
Compare
Done |
52d8a5a
to
5979b49
Compare
…nal core boot The builder is able to create bundles not containing "sap.ui.requireSync" calls, so that the bundles can be used also within UI5 Version 2 and later, where this internal API is not available anymore. JIRA: CPOUI5FOUNDATION-789 Co-authored-by: Merlin Beutlberger <m.beutlberger@sap.com>
5979b49
to
5adecf8
Compare
The builder is able to create bundles not containing "sap.ui.requireSync" calls, so that the bundles can be used also within UI5 Version 2 and later, where this internal API is not available anymore.
JIRA: CPOUI5FOUNDATION-789