Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance custom default paths logic to allow specifying a branch #238

Merged
merged 28 commits into from
Feb 5, 2025

Conversation

phgermanov
Copy link
Contributor

Updated path processing logic in processCustomDefaultsPath function to handle different path types correctly:

  • Absolute GitHub URLs are preserved as-is
  • Paths with explicit branch references (e.g., org/repo/path@branch) are converted to full GitHub URLs
  • Simple file paths (relative paths starting with ./ or ../ or paths without /) are kept as-is
  • Other paths are treated as repository-relative and get the full GitHub URL with current branch

Copy link
Contributor

@bitmaskit bitmaskit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have to run npm run dist:update after commit or npm run dist:build before commit . I think thats why there are lint errors

@phgermanov phgermanov force-pushed the phgermanov/custom-default-paths-enhancement branch from 4256ef9 to 067b78c Compare January 28, 2025 15:09
src/config.ts Outdated Show resolved Hide resolved
src/config.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
phgermanov and others added 3 commits February 5, 2025 16:27
Co-authored-by: Googlom <36107508+Googlom@users.noreply.github.com>
@Googlom Googlom self-requested a review February 5, 2025 15:21
@phgermanov phgermanov merged commit 67cb569 into main Feb 5, 2025
14 of 15 checks passed
@phgermanov phgermanov deleted the phgermanov/custom-default-paths-enhancement branch February 5, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants