-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tbi(telemetry): update init settings, bump azure applicationinsights and stablise tests #1714
Conversation
🦋 Changeset detectedLatest commit: 130addf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@cianmSAP do you know a little more about the instabilities? What is taking so long? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cianmSAP
- Timeout inc. to avoid timeout on long running tests.
- Nothing to be tested
After some investigation I can see that
can take a 3-4 seconds to complete in some cases (atleast on my machine). I think the timeout here covers this unpredictability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update.
updates are clear and covered by tests.
changeset ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving
|
#1417
Adds
watchTelemetrySettingStore
as a required option to ToolsSuiteTelemetryInitSettings. Using a watch on the store is not always desirableBump
applicationinsights
to2.9.2
to incorporate fix Minimal fix for #1226 microsoft/ApplicationInsights-node.js#1241 displayingApplicationInsights:Invalid JSON config file when using APPLICATIONINSIGHTS_CONNECTION_STRING
errorIncreasing timeout for tests due to instabilities. Also making paths dynamic so they can be ran with tools like jest-runner