Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Left nav small enhancements #4159

Merged
merged 6 commits into from
Feb 27, 2025
Merged

Left nav small enhancements #4159

merged 6 commits into from
Feb 27, 2025

Conversation

hardl
Copy link
Contributor

@hardl hardl commented Feb 19, 2025

  • calls blur() on mouse up in btp left nav to avoid weird overlap
  • adds current nodes context to navheader for renderer

hardl added 2 commits February 19, 2025 16:38
@hardl
blur onclick
ff4ad68 
ctx in navheader renderer
@hardl
prettier
a28f7e6
@JohannesDoberer JohannesDoberer self-assigned this Feb 20, 2025
@JohannesDoberer JohannesDoberer removed their assignment Feb 25, 2025
@walmazacn walmazacn self-assigned this Feb 26, 2025
walmazacn
walmazacn approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@walmazacn walmazacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left nav item loses focus when mouseup method is triggered - if 'btpToolLayout' is enabled

@JohannesDoberer JohannesDoberer merged commit ee8736e into main Feb 27, 2025
11 checks passed
@JohannesDoberer JohannesDoberer deleted the left-nav-small-enhancements branch February 27, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walmazacn walmazacn walmazacn approved these changes

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@VincentUllal VincentUllal Awaiting requested review from VincentUllal VincentUllal is a code owner

@smahati smahati Awaiting requested review from smahati smahati is a code owner

@amilewskaa amilewskaa Awaiting requested review from amilewskaa amilewskaa is a code owner

Assignees

@walmazacn walmazacn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hardl @walmazacn @JohannesDoberer