Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tpc via client #3983

Merged
merged 16 commits into from
Oct 10, 2024
Merged

Disable tpc via client #3983

merged 16 commits into from
Oct 10, 2024

Conversation

JohannesDoberer
Copy link
Contributor

@JohannesDoberer JohannesDoberer commented Oct 7, 2024

When LuigiClient functionality will be tested with testing-utilities lib the option to disable 3rd party cookie check with core has no effect. This PR introduces a possibility to disable 3rd party cookie check via LuigiClient.

@JohannesDoberer JohannesDoberer added the enhancement New feature or request label Oct 8, 2024
@JohannesDoberer JohannesDoberer marked this pull request as ready for review October 8, 2024 18:58
Copy link
Contributor

@walmazacn walmazacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@walmazacn walmazacn self-assigned this Oct 10, 2024
Copy link
Contributor

@walmazacn walmazacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JohannesDoberer JohannesDoberer merged commit c8102b9 into main Oct 10, 2024
11 checks passed
@JohannesDoberer JohannesDoberer deleted the disable-tpc-via-client branch October 10, 2024 10:08
@JohannesDoberer JohannesDoberer mentioned this pull request Nov 5, 2024
@JohannesDoberer JohannesDoberer mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants