Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes client DOM XSS issue #3974

Merged
merged 8 commits into from
Oct 10, 2024
Merged

Fixes client DOM XSS issue #3974

merged 8 commits into from
Oct 10, 2024

Conversation

walmazacn
Copy link
Contributor

Description

Changes proposed in this pull request:

  • fixes client DOM XSS issue from Checkmarx One report

Related issue(s)

Fixes #3972

@walmazacn walmazacn linked an issue Oct 2, 2024 that may be closed by this pull request
Checkmarx One report - Client DOM XSS #3972
Closed
@walmazacn
Copy link
Contributor Author

It seems Checkmarx test run against this branch is successful - reported issue is no longer detected

JohannesDoberer
JohannesDoberer approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walmazacn walmazacn merged commit aad422e into main Oct 10, 2024
12 checks passed
@walmazacn walmazacn deleted the 3972-checkmarx-one-client-dom-xss branch October 10, 2024 08:58
@JohannesDoberer JohannesDoberer added the internal Stuff like NFRs, CI pipeline label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@VincentUllal VincentUllal Awaiting requested review from VincentUllal VincentUllal is a code owner

@smahati smahati Awaiting requested review from smahati smahati is a code owner

@amilewskaa amilewskaa Awaiting requested review from amilewskaa amilewskaa is a code owner

Assignees
No one assigned
Labels
internal Stuff like NFRs, CI pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checkmarx One report - Client DOM XSS
2 participants
@walmazacn @JohannesDoberer