Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates rollup version #3956

Merged
merged 23 commits into from
Oct 7, 2024
Merged

Updates rollup version #3956

merged 23 commits into from
Oct 7, 2024

Conversation

@walmazacn walmazacn requested a review from hardl as a code owner September 27, 2024 13:20
@walmazacn walmazacn linked an issue Sep 27, 2024 that may be closed by this pull request
@ndricimrr ndricimrr self-assigned this Sep 30, 2024
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use this PR to update rollup wherever possible that includes the following:

  • client-frameworks-support/client-support-angular
  • core
  • test/e2e-test-application
  • website/docs
  • core/examples/luigi-example-angular
  • core/examples/luigi-example-vue
  • core/examples/luigi-example-angular

I think rollup is used there but as a "child" dependency of another dependency. You can find these if you search "rollup" and it will show up in package-lock.jsons that you can use to find out which parent dependency has it as a child and update that. I think this issue is quite popular and many other packages might have already updated rollup internally.

Example: @angular-devkit/build-angular depends on "rollup": "4.20.0", on our luigi-example-angular and it was already bumped on their side here

In case some pacakge that we use hasn't updated their rollup dep then you can note it down in the PR description. (Maybe we can also fix it with "overrides")

@walmazacn
Copy link
Contributor Author

walmazacn commented Oct 1, 2024

I updated what's possible without breaking changes. The following stuff cannot be updated easily:

  • 'core'
  • 'client-frameworks-support\client-support-angular'

Btw, it seems rollup in 'core/examples' is already safe enough (version 4+)

@ndricimrr
Copy link
Contributor

Looking at the reports following ranges are affected for rollup, so its not just older versions. v4 too :

< 2.79.2           , patch = 2.79.2
>= 3.0.0, < 3.29.5 , patch = 3.29.5
>= 4.0.0, < 4.22.4 , patch = 4.22.5

So I think we should update the core examples as well if they are in the range and are not too much of a hassle to update.

Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about the container

Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and ran the packages locally to make sure. And it all looks good.

@walmazacn walmazacn merged commit 21f345a into main Oct 7, 2024
11 checks passed
@walmazacn walmazacn deleted the 3953-update-rollup-version-in-repo branch October 7, 2024 08:17
@JohannesDoberer JohannesDoberer added the internal Stuff like NFRs, CI pipeline label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Stuff like NFRs, CI pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update rollup version in repo
3 participants