-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates rollup version #3956
Updates rollup version #3956
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use this PR to update rollup wherever possible that includes the following:
- client-frameworks-support/client-support-angular
- core
- test/e2e-test-application
- website/docs
- core/examples/luigi-example-angular
- core/examples/luigi-example-vue
- core/examples/luigi-example-angular
I think rollup is used there but as a "child" dependency of another dependency. You can find these if you search "rollup" and it will show up in package-lock.jsons that you can use to find out which parent dependency has it as a child and update that. I think this issue is quite popular and many other packages might have already updated rollup internally.
Example: @angular-devkit/build-angular
depends on "rollup": "4.20.0",
on our luigi-example-angular
and it was already bumped on their side here
In case some pacakge that we use hasn't updated their rollup dep then you can note it down in the PR description. (Maybe we can also fix it with "overrides")
I updated what's possible without breaking changes. The following stuff cannot be updated easily:
Btw, it seems rollup in 'core/examples' is already safe enough (version 4+) |
Looking at the reports following ranges are affected for rollup, so its not just older versions. v4 too :
So I think we should update the core examples as well if they are in the range and are not too much of a hassle to update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about the container
…om/SAP/luigi into 3953-update-rollup-version-in-repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built and ran the packages locally to make sure. And it all looks good.
Description
Changes proposed in this pull request:
Related issue(s)
Resolves #3953 | See also related issues: