Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go version to 1.23 and removed some helper methods in favor of STD library #5200

Merged
merged 6 commits into from
Dec 12, 2024

Conversation

bitmaskit
Copy link
Contributor

Description

Checklist

  • Tests
  • Documentation
  • Inner source library needs updating

@bitmaskit bitmaskit requested review from a team as code owners December 6, 2024 10:22
@bitmaskit
Copy link
Contributor Author

bitmaskit commented Dec 12, 2024

/it-go

Copy link
Contributor

@phgermanov phgermanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@CCFenner CCFenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good

@bitmaskit bitmaskit merged commit dfd947b into master Dec 12, 2024
13 checks passed
@bitmaskit bitmaskit deleted the update-go-version branch December 12, 2024 15:32
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Jan 10, 2025
…ix-fix

* origin/master: (36 commits)
  Revert changes done to release action (SAP#5228)
  Update release-go.yml (SAP#5227)
  Remove README and CONTRIBUTING files from release 3rd try (SAP#5226)
  fix(setupCommonPipelineEnvironment): handling tags from scm info (SAP#5219)
  Remove README and CONTRIBUTING files from release 2nd try (SAP#5225)
  [CxONE] Improve report: add Low findings; Proposed Not Exploitable state (SAP#5223)
  Remove README and CONTRIBUTING files from release (SAP#5221)
  fix(naming): Rename Trust Engine to System Trust (SAP#5217)
  abapEnvironmentAssemblePackages Check for Build Errors (SAP#5214)
  docs: fix npmExuceteTests documentation formatting issues (SAP#5218)
  feat: Introduce new npmExecuteTests step (SAP#5124)
  fix(cloudFoundryDeploy): argument list too long (SAP#5216)
  Revert "Fix deployment failure with CF if password contains special char (SAP#5197)" (SAP#5215)
  chore(trustengine): Rename Trust Engine to System Trust in logs and docs (SAP#5210)
  Fix deployment failure with CF if password contains special char (SAP#5197)
  Update go version to 1.23 and removed some helper methods in favor of STD library (SAP#5200)
  Added validation for buildTool and buildDescriptorFile (SAP#5193)
  Unstash class files for Compliance stage (SAP#5192) (SAP#5204)
  fix(documentation): check param for jenkinsParams before appending Jenkins-specific text (SAP#5203)
  Align description of ADO and GHA (SAP#5202)
  ...
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Jan 10, 2025
* origin/master: (36 commits)
  Revert changes done to release action (SAP#5228)
  Update release-go.yml (SAP#5227)
  Remove README and CONTRIBUTING files from release 3rd try (SAP#5226)
  fix(setupCommonPipelineEnvironment): handling tags from scm info (SAP#5219)
  Remove README and CONTRIBUTING files from release 2nd try (SAP#5225)
  [CxONE] Improve report: add Low findings; Proposed Not Exploitable state (SAP#5223)
  Remove README and CONTRIBUTING files from release (SAP#5221)
  fix(naming): Rename Trust Engine to System Trust (SAP#5217)
  abapEnvironmentAssemblePackages Check for Build Errors (SAP#5214)
  docs: fix npmExuceteTests documentation formatting issues (SAP#5218)
  feat: Introduce new npmExecuteTests step (SAP#5124)
  fix(cloudFoundryDeploy): argument list too long (SAP#5216)
  Revert "Fix deployment failure with CF if password contains special char (SAP#5197)" (SAP#5215)
  chore(trustengine): Rename Trust Engine to System Trust in logs and docs (SAP#5210)
  Fix deployment failure with CF if password contains special char (SAP#5197)
  Update go version to 1.23 and removed some helper methods in favor of STD library (SAP#5200)
  Added validation for buildTool and buildDescriptorFile (SAP#5193)
  Unstash class files for Compliance stage (SAP#5192) (SAP#5204)
  fix(documentation): check param for jenkinsParams before appending Jenkins-specific text (SAP#5203)
  Align description of ADO and GHA (SAP#5202)
  ...
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Jan 10, 2025
…fig-fix

* origin/master: (36 commits)
  Revert changes done to release action (SAP#5228)
  Update release-go.yml (SAP#5227)
  Remove README and CONTRIBUTING files from release 3rd try (SAP#5226)
  fix(setupCommonPipelineEnvironment): handling tags from scm info (SAP#5219)
  Remove README and CONTRIBUTING files from release 2nd try (SAP#5225)
  [CxONE] Improve report: add Low findings; Proposed Not Exploitable state (SAP#5223)
  Remove README and CONTRIBUTING files from release (SAP#5221)
  fix(naming): Rename Trust Engine to System Trust (SAP#5217)
  abapEnvironmentAssemblePackages Check for Build Errors (SAP#5214)
  docs: fix npmExuceteTests documentation formatting issues (SAP#5218)
  feat: Introduce new npmExecuteTests step (SAP#5124)
  fix(cloudFoundryDeploy): argument list too long (SAP#5216)
  Revert "Fix deployment failure with CF if password contains special char (SAP#5197)" (SAP#5215)
  chore(trustengine): Rename Trust Engine to System Trust in logs and docs (SAP#5210)
  Fix deployment failure with CF if password contains special char (SAP#5197)
  Update go version to 1.23 and removed some helper methods in favor of STD library (SAP#5200)
  Added validation for buildTool and buildDescriptorFile (SAP#5193)
  Unstash class files for Compliance stage (SAP#5192) (SAP#5204)
  fix(documentation): check param for jenkinsParams before appending Jenkins-specific text (SAP#5203)
  Align description of ADO and GHA (SAP#5202)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants