feat(gcpPublishEvent): Add additionalEventData param #4928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anilkeshav27
approved these changes
May 16, 2024
|
/it-go |
|
maxatsap
pushed a commit
to maxatsap/jenkins-library
that referenced
this pull request
Jul 23, 2024
* add additionalEventData param * fix double JSON marshalling * go generate * add logging of events and config * change logging to debug * add event log * fix CloudEvent JSON type * apply review feedback * fix log * add missing error handling --------- Co-authored-by: jliempt <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to insert additional data into the
eventDataJSON, which is useful when theeventDatacomes from the pipeline env.This also fixes the format of the
"data"part of the CloudEvent. If you pass a string tocloudEvent.SetData(), it will be marshalled and ends up with duplicated escape characters (for example{\\\\"testKey\\\\": \\\\"testValue\\\\"}), which causes problems when unmarshalling the data. Passing amap[string]interface{}solves it.Changes