orchestrator(GHActions): align GetJobURL method with Piper's expectations #4685
+62
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstarostin
commented
Nov 21, 2023
Googlom
reviewed
Nov 21, 2023
|
/it-go |
CCFenner
reviewed
Nov 22, 2023
vstarostin
commented
Nov 27, 2023
| return g.currentJob.HtmlURL | ||
| fileName := workflowFileName() | ||
| if fileName == "" { | ||
| return "" |
There was a problem hiding this comment.
if there is something wrong with GITHUB_WORKFLOW_REF, the GetJobURL returns an empty string, then the telemetry package handles it and put n/a to the PipelineURLHash, so that we know that something wrong
|
Kudos, SonarCloud Quality Gate passed!
|
|
/it-go |
CCFenner
approved these changes
Nov 27, 2023
maxatsap
pushed a commit
to maxatsap/jenkins-library
that referenced
this pull request
Jul 23, 2024
…ions (SAP#4685) * Align build and job urls with what is expected by piper * Add comments, delete unused func * Clean up * Update tests * Update GetJobURL * Fix test * Update * Clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The GetJobURL (and GetBuildURL) functions are (particularly) used by the telemetry package to populate the PipelineURLHash and BuildURLHash.
The expected value of the PipelineURLHash is a URL (hashed value) that points to the project’s pipelines.
The expected value of the BuildURLHash is a URL (hashed value) that points to all pipelines of the currently running workflow. Not a particular stage.
Therefore, we don't need a GitHub API call to obtain a job (piper stage) URL. We need the workflow URL, which can be accessed from GitHub environment variables.
Related: SAP/project-piper-action#161