Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning message when cf native builds uses bg deployment #4646

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Add warning message when cf native builds uses bg deployment #4646

merged 4 commits into from
Oct 30, 2023

Conversation

srinikitha09
Copy link
Contributor

Changes

  • Tests
  • Documentation

@srinikitha09
Copy link
Contributor Author

@o-liver , @dimitrij-afonitschkin is this how we want?

@srinikitha09 srinikitha09 force-pushed the add_warning_cf_native_builds branch from 48eac80 to 70ef263 Compare October 26, 2023 11:39
dimitrij-afonitschkin
dimitrij-afonitschkin approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@dimitrij-afonitschkin dimitrij-afonitschkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

o-liver
o-liver requested changes Oct 27, 2023
View reviewed changes
cmd/cloudFoundryDeploy.go Outdated Show resolved Hide resolved
srinikitha09 and others added 2 commits October 27, 2023 13:24
@srinikitha09 @o-liver
Adjust warning message
7151e39 
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
@srinikitha09
Fix go format issue
9880c00
@srinikitha09 srinikitha09 requested a review from o-liver October 27, 2023 11:41
@srinikitha09
Copy link
Contributor Author

@o-liver Do you think we need to add the docu in any other places as well?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

o-liver
o-liver approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@o-liver o-liver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @anilkeshav27 Do you want to have a look?

@o-liver o-liver marked this pull request as ready for review October 30, 2023 11:30
@o-liver o-liver requested a review from a team as a code owner October 30, 2023 11:30
@o-liver
Copy link
Member

o-liver commented Oct 30, 2023

/it

@o-liver o-liver enabled auto-merge (squash) October 30, 2023 11:30
@o-liver o-liver merged commit 5dea623 into master Oct 30, 2023
@o-liver o-liver deleted the add_warning_cf_native_builds branch October 30, 2023 11:40
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@srinikitha09 @o-liver @maxatsap
Add warning message when cf native builds uses bg deployment (SAP#4646)
479a390 
* Add warning message when cf native builds uses bg deployment

---------

Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@o-liver o-liver o-liver approved these changes

@dimitrij-afonitschkin dimitrij-afonitschkin dimitrij-afonitschkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srinikitha09 @o-liver @dimitrij-afonitschkin