Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed list item misalignment issue #1474

Merged
merged 3 commits into from
Jul 9, 2019
Merged

fix: Fixed list item misalignment issue #1474

merged 3 commits into from
Jul 9, 2019

Conversation

JYSW380
Copy link
Contributor

@JYSW380 JYSW380 commented Jun 3, 2019 •
edited by InnaAtanasova
Loading

Closes #1316

@JYSW380 JYSW380 requested a review from InnaAtanasova June 3, 2019 14:44
@CLAassistant
Copy link

CLAassistant commented Jun 3, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Jun 3, 2019 •
edited
Loading

Deploy preview for fundamental ready!

Built with commit 1f7fdd7

https://deploy-preview-1474--fundamental.netlify.com

@InnaAtanasova InnaAtanasova changed the title #1316: fixed List item misalignment issue fix: Fixed list item misalignment issue Jun 3, 2019
@JYSW380 JYSW380 force-pushed the fix/#1316-list-vertical-misalignment-issue branch from 9d01598 to 5874c65 Compare June 3, 2019 19:58
@ChristianKienle
Copy link

Just one question: How can this be approved even though there are build errors? Or are failing builds okay in this repo?

@JYSW380 JYSW380 force-pushed the fix/#1316-list-vertical-misalignment-issue branch from 5874c65 to c30cb21 Compare June 4, 2019 18:01
@saad-mo saad-mo added this to the sprint 13 - Oathkeeper milestone Jun 5, 2019
@droshev droshev self-requested a review June 5, 2019 13:57
droshev
droshev requested changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@droshev droshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's wait until we move all merge commits in fd-styles

@saad-mo
Copy link
Contributor

saad-mo commented Jun 10, 2019

@droshev can this be merged now?

@saad-mo
Copy link
Contributor

saad-mo commented Jun 10, 2019

Just one question: How can this be approved even though there are build errors? Or are failing builds okay in this repo?

maybe the approved checked the changes locally. we can't merge PR until all the build errors are fixed.

@InnaAtanasova
Copy link
Contributor

The merge button is disabled if there are build errors

@saad-mo
Copy link
Contributor

saad-mo commented Jun 21, 2019

@droshev pls unblock this PR so that it can be merged

@droshev
Copy link
Contributor

droshev commented Jun 21, 2019

@saad-mo this is issue is still in progress. I would even take the PR back until it is fixed in styles

@JYSW380 JYSW380 closed this Jun 21, 2019
@JYSW380 JYSW380 reopened this Jun 28, 2019
JYSW380
JYSW380 commented Jun 28, 2019
View reviewed changes
Copy link
Contributor Author

@JYSW380 JYSW380 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is exact same issue refer to fd-style #64

@JYSW380 JYSW380 requested a review from saad-mo June 28, 2019 18:01
@JYSW380 JYSW380 merged commit e27c12d into master Jul 9, 2019
@JYSW380 JYSW380 deleted the fix/#1316-list-vertical-misalignment-issue branch July 9, 2019 18:52
droshev pushed a commit that referenced this pull request Jul 16, 2020
@JYSW380 @droshev
fix: Fixed list item misalignment issue (#1474)
7d37963 
* #1316: fixed List item misalignment issue

* fixed misalign icon with text

* add updated test png files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droshev droshev droshev approved these changes

@saad-mo saad-mo saad-mo approved these changes

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
sprint 13 - Hot Pie
Development

Successfully merging this pull request may close these issues.

List item elements vertical alignment
6 participants
@JYSW380 @CLAassistant @ChristianKienle @saad-mo @InnaAtanasova @droshev