-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: toggle updates #1466
feat: toggle updates #1466
Conversation
Deploy preview for fundamental ready! Built with commit 495f4f1 |
I am fine with putting an icon inside the toggle, but what about the text inside. In English we have short words |
@droshev I would suggest always putting the value such as on/off should be outside to account for longer translations. |
This is something you would have to file under "get feedback from GD". At this point this is how they are suggesting we do it. There isn't a design for the label outside. |
@LeoT7508 I just checked the latest Sketch file (v. 1.66) and they still have a version with the label on the outside. |
Ah yes, I missed that, thanks for the correction. @saad-mo i'll put that in the design sheet quickly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@droshev, @jeannewalters - If you look at the documentation page I have a note on how you can increase the width of the toggle if you need to support more than 3 characters. I feel we need to provide this version as it is part of the design specs from GD. Toggles always supported a label on the outside. I'll update the docs page to show this along with leo's updates. |
It would be useful to document that we recommend labeling the text next to the |
@droshev @jeannewalters @LeoT7508 Documentation page has been updated with the latest text from @jeannewalters please review. as recommended, the documentation does not include the toggle with labels on the inside. we can leave it in the code if someone requests it down the line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good.
these changes have been applied to fundamental-styles as well |
* Update toggle component to match design specs
Closes #969
compact
size optionlabel
modifier to support inline labelsemantic
modifier for the semantic version of the toggle with colors and iconTest
Changelog
New
compact
size modifierlabel
modifiersemantic
modifierChanged
Removed
nothing. this is a non-breaking change with no changes to existing markup or modifiers