Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: toggle updates #1466

Merged
merged 8 commits into from
Jun 6, 2019
Merged

feat: toggle updates #1466

merged 8 commits into from
Jun 6, 2019

Conversation

saad-mo
Copy link
Contributor

@saad-mo saad-mo commented May 29, 2019

Closes #969

  • Updated toggle to the latest design
  • added compact size option
  • added label modifier to support inline label
  • added semantic modifier for the semantic version of the toggle with colors and icon
  • updated documentation to reflect the newly available options

Screen Shot 2019-05-29 at 3 45 29 PM

Screen Shot 2019-05-29 at 3 45 49 PM

Screen Shot 2019-05-29 at 3 45 34 PM

Screen Shot 2019-05-29 at 3 45 54 PM

Test

Changelog

New

  • compact size modifier
  • label modifier
  • semantic modifier

Changed

  • refactored scss to support default width extension if the labels need to be longer than three characters

Removed

nothing. this is a non-breaking change with no changes to existing markup or modifiers

@saad-mo saad-mo requested review from droshev, jbadan and LeoT7508 May 29, 2019 20:55
@netlify
Copy link

netlify bot commented May 29, 2019

Deploy preview for fundamental ready!

Built with commit 495f4f1

https://deploy-preview-1466--fundamental.netlify.com

@saad-mo
Copy link
Contributor Author

saad-mo commented May 29, 2019

@droshev
Copy link
Contributor

droshev commented May 30, 2019

I am fine with putting an icon inside the toggle, but what about the text inside. In English we have short words ON and OFF, but in other languages this is longer, which won't fit.
@jeannewalters @LeoT7508 what do you think?

@jeannewalters
Copy link
Member

@droshev I would suggest always putting the value such as on/off should be outside to account for longer translations.

@LeoT7508
Copy link

@jeannewalters @droshev

This is something you would have to file under "get feedback from GD". At this point this is how they are suggesting we do it. There isn't a design for the label outside.

@jeannewalters
Copy link
Member

@LeoT7508 I just checked the latest Sketch file (v. 1.66) and they still have a version with the label on the outside.

@LeoT7508
Copy link

@jeannewalters

Ah yes, I missed that, thanks for the correction.

@saad-mo i'll put that in the design sheet quickly.

Copy link

@LeoT7508 LeoT7508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saad-mo

We have 2 updates:

  1. Add the option for a label outside.
  2. Add the outline for selected state.

@saad-mo
Copy link
Contributor Author

saad-mo commented May 30, 2019

@droshev, @jeannewalters - If you look at the documentation page I have a note on how you can increase the width of the toggle if you need to support more than 3 characters. I feel we need to provide this version as it is part of the design specs from GD.

Toggles always supported a label on the outside. I'll update the docs page to show this along with leo's updates.

@droshev
Copy link
Contributor

droshev commented May 31, 2019

It would be useful to document that we recommend labeling the text next to the toggle. you write that for 1-3 latin letters then can put it inside.

@saad-mo
Copy link
Contributor Author

saad-mo commented Jun 5, 2019

@droshev @jeannewalters @LeoT7508

Documentation page has been updated with the latest text from @jeannewalters please review.

as recommended, the documentation does not include the toggle with labels on the inside. we can leave it in the code if someone requests it down the line.

Copy link

@LeoT7508 LeoT7508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good.

@saad-mo saad-mo merged commit 3e18dc5 into master Jun 6, 2019
@saad-mo saad-mo deleted the feature/toggle-udpates branch June 6, 2019 19:23
@saad-mo saad-mo restored the feature/toggle-udpates branch June 10, 2019 15:31
@saad-mo
Copy link
Contributor Author

saad-mo commented Jul 15, 2019

these changes have been applied to fundamental-styles as well

droshev pushed a commit that referenced this pull request Jul 16, 2020
* Update toggle component to match design specs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fiori 3.0 Visual Update: Toggle Variation, size, & states
4 participants