Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simplify playground experience #1458

Merged
merged 7 commits into from
May 24, 2019
Merged

fix: simplify playground experience #1458

merged 7 commits into from
May 24, 2019

Conversation

jbadan
Copy link
Contributor

@jbadan jbadan commented May 21, 2019

npm run start:playground will now open a page hosting both the "old" playground and the self contained styles playground. This will help us compare self contained styles better.

Changes to "old" playground:

  • remove css_deps
  • styles are now served from all.scss, which we could easily switch out with all-ie11.scss

Note: this change required updating 70+ tests as they were actually being affected by other styles

Screen Shot 2019-05-21 at 1 44 59 PM

@jbadan jbadan requested a review from a team May 21, 2019 20:49
@netlify
Copy link

netlify bot commented May 21, 2019

Deploy preview for fundamental ready!

Built with commit 182d4bd

https://deploy-preview-1458--fundamental.netlify.com

@bcullman bcullman changed the title fix: simply playground experience fix: simplify playground experience May 21, 2019
@droshev droshev added this to the sprint 12 - Daenerys milestone May 21, 2019
@saad-mo
Copy link
Contributor

saad-mo commented May 22, 2019

is there a way to have a checkbox to switch between all.scss and all-ie11.scss?

@jbadan
Copy link
Contributor Author

jbadan commented May 22, 2019

@saad-mo I don't have that built in yet, but you can always switch line 11 in layout file to be all-ie11.scss.

Copy link
Contributor

@greg-a-smith greg-a-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply putting a "block" on this PR for a pair review session.

@jbadan
Copy link
Contributor Author

jbadan commented May 23, 2019

@saad-mo Added an additional playground - npm run start:playground:ie11 will load all-ie11.scss 🎉

Copy link
Contributor

@greg-a-smith greg-a-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 🚢

@jbadan jbadan merged commit 7441cd8 into master May 24, 2019
@jbadan jbadan deleted the fix/update-playground branch May 24, 2019 13:30
droshev pushed a commit that referenced this pull request Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants