fix: create playground to evaluate self-contained styles #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental ready! Built with commit e85395e |
|
Failing tests will be solved by #1438 |
greg-a-smith
reviewed
May 6, 2019
| @@ -213,65 +217,28 @@ router.get('/:key', (req, res) => { | |||
| } finally { | |||
|
|
|||
| } | |||
| signale.info(`Requested http://localhost:3030/${key}`); | |||
| res.render(`${key}/index`, Object.assign(GLOBALS, { id: key, component: getStarterData(), data, libs: getLibs(req.query.lib) })); | |||
There was a problem hiding this comment.
Is the libs no longer needed?
There was a problem hiding this comment.
It was never being used - it should have been living on a branch as it wasn't a fully developed feature.
jbadan
commented
May 7, 2019
| @@ -79,8 +78,6 @@ module.exports = { | |||
| "--disable-dev-shm-usage" | |||
| ] | |||
| }, | |||
| "asyncCaptureLimit": 1, | |||
| "asyncCompareLimit": 1, | |||
There was a problem hiding this comment.
This is what was making the tests run so slowly
greg-a-smith
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr leverages the existing playground to create a secondary one to be used to evaluate if styles are self contained and what would need to be done to have each component's scss file be self contained.
The playgrounds can be run at the same time in order to compare with
npm run start:playgroundandnpm run start:playground:selfContained. << That needs a new name 🤷♀Regular playground
core.scsscomponents/componentName.scsscss_depsarray, see: https://github.com/SAP/fundamental/blob/master/test/templates/action-bar/index.njk#L10all styles work together for consumers using
fiori-fundamentals.css(akaall.scss)Self contained playground
components/componentName.scssOther notable changes:
resources/layout.cssto prevent confusion with inline stylesresourcesdirectory