fix: renaming private scss files

[jbadan]

This is prerequisite work for moving to a new node-sass and post-css build pipeline.

These files are currently not the in the dist folder, renaming them with an underscore will prevent them from being picked up by node-sass. Note: the imports of these files do not need to be updated, seecore.scss as an example. @import "core/root" works the same as @import "core/_root"

[joseegm]

Test Version for this PR was deployed

Built with commit 5602d63

https://deploy-preview-1379--fundamental.netlify.com

[bcullman]

Seems like the references to these files should also be fixed.

I get that SCSS may allow for name -> _name substitution, but I think that is not intuitive.

[bcullman]

After further discussion with @jbadan, we have determined that it is common in SASS to import .scss without the underscore or even the file extension.

for example, see: https://github.com/twbs/bootstrap/blob/master/scss/bootstrap.scss

So, disregard my prior comment.

[eboyer]

@bcullman @jbadan ~ Just to confirm then, @jbadan's original statement of references not being needed to be updated still holds true?

[bcullman]

@eboyer correct.