Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Popover popper styles #1366

Merged
merged 5 commits into from
Apr 4, 2019
Merged

Conversation

greg-a-smith
Copy link
Contributor

Added styles specific to a custom implementation of popovers using popper.js.

Changelog

New

  • Added fd-popover__popper styles.

@greg-a-smith greg-a-smith requested a review from a team April 1, 2019 16:08
@joseegm
Copy link
Contributor

joseegm commented Apr 1, 2019

Test Version for this PR was deployed

Built with commit 3091f13

https://deploy-preview-1366--fundamental.netlify.com

@jbadan
Copy link
Contributor

jbadan commented Apr 1, 2019

@greg-a-smith There is something wrong with travis and github communicating today - you might have to push an empty commit to get it to rebuild.

Copy link
Contributor

@eboyer eboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on @greg-a-smith! This is great.

@greg-a-smith greg-a-smith merged commit c756cc4 into master Apr 4, 2019
@greg-a-smith greg-a-smith deleted the feat/popover-popper-styles branch April 4, 2019 13:47
droshev pushed a commit that referenced this pull request Jul 16, 2020
* Added styles for popovers using popper.js

* Added playground examples of popover using popper.js

* Removed fd-popover-background-color css variable and just used fd-color-background-2

* Added notes about popper-specific popover classes to docs

* Empty commit to force rebuild
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants