-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade fd-styles to latest and fix components due to broken changes from fd-styles #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fundamental-react ready!- PR deployment from 1471 to 1479 is partly broken since It lacks serving FD theming css. Please checked the ones after PR 1480;
To edit notification comments on pull requests, go to your Netlify site settings. |
droshev
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade upgrade fundamental-styles to latest version , apply latest horizon styles:
Refined these components under latest fundamental-styles:
There are some broken changes caused by fundamental-styles's upgrade (if your test case rely on the class or x-path , you may need to change that):
Popover:
Changed
.fd-popover__popper
to.fd-popover__body
Changed
.fd-popover__innerRef
to.fd-popover__innerRef
Calendar:
Ad one more
fd-calendar__content--dates
besides.fd-calendar__content
Loading Indicator:
.fd-busy-indicator--circle-0
to.fd-busy-indicator__circle
.fd-busy-indicator--circle-1
to.fd-busy-indicator__circle
.fd-busy-indicator--circle-2
to.fd-busy-indicator__circle
Shell bar:
.fd-counter .fd-counter--notification .fd-shellbar__counter--notification
to.fd-badge
Reused Pagination's old CSS, due to new pagination from Fundamental Styles is totally redesigned, which need a new implementation, later need rewrite the whole pagination component