Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade fd-styles to latest and fix components due to broken changes from fd-styles #1471

Merged
merged 21 commits into from
Feb 6, 2023

Conversation

Vita-Meow
Copy link
Contributor

@Vita-Meow Vita-Meow commented Feb 2, 2023

upgrade upgrade fundamental-styles to latest version , apply latest horizon styles:

Refined these components under latest fundamental-styles:

There are some broken changes caused by fundamental-styles's upgrade (if your test case rely on the class or x-path , you may need to change that):

  • Popover:
    Changed .fd-popover__popper to .fd-popover__body
    Changed .fd-popover__innerRef to .fd-popover__innerRef

  • Calendar:
    Ad one more fd-calendar__content--dates besides .fd-calendar__content

  • Loading Indicator:
    .fd-busy-indicator--circle-0 to .fd-busy-indicator__circle
    .fd-busy-indicator--circle-1 to .fd-busy-indicator__circle
    .fd-busy-indicator--circle-2 to .fd-busy-indicator__circle

  • Shell bar:
    .fd-counter .fd-counter--notification .fd-shellbar__counter--notification to .fd-badge


Reused Pagination's old CSS, due to new pagination from Fundamental Styles is totally redesigned, which need a new implementation, later need rewrite the whole pagination component

@netlify
Copy link

netlify bot commented Feb 2, 2023

Deploy Preview for fundamental-react ready!

- PR deployment from 1471 to 1479 is partly broken since It lacks serving FD theming css. Please checked the ones after PR 1480;

Name Link
🔨 Latest commit fe82186
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-react/deploys/63e11bb0e7f86e0008bdbb0f
😎 Deploy Preview https://deploy-preview-1471--fundamental-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cla-assistant
Copy link

cla-assistant bot commented Feb 3, 2023

CLA assistant check
All committers have signed the CLA.

@Vita-Meow Vita-Meow requested review from jbadan, greg-a-smith and droshev and removed request for jbadan February 6, 2023 15:25
@Vita-Meow Vita-Meow changed the title fix: upgrade fd-styles fix: upgrade fd-styles to lastest and fix components due to broken changes from fd-styles Feb 6, 2023
@Vita-Meow Vita-Meow changed the title fix: upgrade fd-styles to lastest and fix components due to broken changes from fd-styles fix: upgrade fd-styles to latest and fix components due to broken changes from fd-styles Feb 6, 2023
@Vita-Meow Vita-Meow removed the request for review from jbadan February 6, 2023 15:33
@droshev droshev merged commit 6e58a23 into SAP:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants