feat: add title to sidenav #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fundamental-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…yn321/fundamental-react into sidenav-title-and-wrapping
16 tasks
dariadomagala-sap
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
titleon hover onSideNavgroup title andSideNavitem. It defaults toname, but it would show[Object object]ifnameis a component (and not a plain string), so I had to add an optionaltitleprop.SideNav- although the default class specifiestext-overflowandoverflow, it also setsdisplay: flex, which disables the former... I couldn't add custom SCSS (build fails) nor CSS (*.css files aren't copied), so I went with inline style approach.