feat: update react-popper to support react18 #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for fundamental-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Vita-Meow
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR update
react-popperdependency to latest version, so that popover component can have correct alignment underReact 18strictMode.I have tested it in my own React 18 project, all the component seem to work fine, but I'm not confident about that.
I was trying to update the test to support React 18, but a lot of code need to be refactored and updated, and I cannot do that in hours, sorry for that. Currently, the project was still tested with React 17, but have set the peerDependency support React 18. I'm not quite sure if it is OK. (This PR does not contain any source code changes)
fixes #1434