fix(core): fixed card layout flickering issue (#8476) #8496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Visit the preview URL for this PR (updated for commit e713072): https://fundamental-ngx-gh--pr8496-pr-fix-fcl-flickerin-s2jtyas3.web.app (expires Mon, 08 Aug 2022 07:15:04 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
N1XUS
approved these changes
Aug 3, 2022
BREAKING CHANGE: * If you rely on dimensions in your unit tests now you have to call component's `updateLayout()` method to organize cards into the columns.
64f526c to
e713072
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr applies changes from previously reverted (original) PR.
Original one was reverted in that PR because of incorrect applying.
Related Issue(s)
Refers to Kafka.
Description
Screenshots
Before:
Notice: scrollbars present for a moment.
Screen.Recording.2022-07-29.at.13.17.56.mov
After:
Screen.Recording.2022-07-29.at.13.10.35.mov
Please check whether the PR fulfills the following requirements
PR Quality
Notice: Relates only to unit testing.