-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): migrate breadcrumbs component #8402
Conversation
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Visit the preview URL for this PR (updated for commit c7a01fa): https://fundamental-ngx-gh--pr8402-feat-8364-breadcrumb-okc5lth6.web.app (expires Thu, 28 Jul 2022 11:40:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
c693905
to
f45308c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when adding new item to the overflow layout it flickers before going to the overflow menu, the same when selecting item from overflow menu in "Forcing visibility of the items" example. it wasn't the case before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now seeing some flickering when adding overflow items that wasn't there before:
Screen.Recording.2022-07-21.at.10.10.14.AM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as you refactored\changed overflow layout a lot in scope of that pr could you please fix unit tests related to it that failed?
6371fdd
to
38157f3
Compare
38157f3
to
3874f78
Compare
Checked. Tests related to Overflow Layout or Breadcrumbs are not causing any errors on local run. |
45d37e8
to
c7a01fa
Compare
Related Issue(s)
closes #8364
Description
Migrated old breadcrumbs overflow mechanism to Overflow Layout component.
Please check whether the PR fulfills the following requirements
During Implementation
PR Quality
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
README.md