Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): migrate breadcrumbs component #8402

Merged
merged 8 commits into from
Jul 25, 2022

Conversation

N1XUS
Copy link
Contributor

@N1XUS N1XUS commented Jul 20, 2022

Related Issue(s)

closes #8364

Description

Migrated old breadcrumbs overflow mechanism to Overflow Layout component.

Please check whether the PR fulfills the following requirements

During Implementation
  1. Visual Testing:
  • visual misalignments/updates
  • check Light/Dark/HCB/HCW themes
  • RTL/LTR - proper rendering and labeling
  • responsiveness(resize)
  • Content Density (Cozy/Compact/(Condensed))
  • States - hover/disabled/focused/active/on click/selected/selected hover/press state
  • Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
  • Mouse vs. Keyboard support
  • Text Truncation
  1. API and functional correctness
  • check for console logs (warnings, errors)
  • API boundary values
  • different combinations of components - free style
  • change the API values during testing
  1. Documentation and Example validations
  • missing API documentation or it is not understandable
  • poor examples
  • Stackblitz works for all examples
  1. Accessibility testing
  2. Browser Testing - Edge, Safari, Chrome, Firefox
PR Quality

@N1XUS N1XUS added the enhancement New feature or request label Jul 20, 2022
@N1XUS N1XUS added this to the Sprint 92 - Vientiane milestone Jul 20, 2022
@N1XUS N1XUS requested review from a team July 20, 2022 12:16
@N1XUS N1XUS self-assigned this Jul 20, 2022
@netlify
Copy link

netlify bot commented Jul 20, 2022

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit c7a01fa
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/62de7eee0e8f490008664608
😎 Deploy Preview https://deploy-preview-8402--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jul 20, 2022

Visit the preview URL for this PR (updated for commit c7a01fa):

https://fundamental-ngx-gh--pr8402-feat-8364-breadcrumb-okc5lth6.web.app

(expires Thu, 28 Jul 2022 11:40:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@N1XUS N1XUS force-pushed the feat/8364-breadcrumbs-overflow-layout branch from c693905 to f45308c Compare July 21, 2022 07:19
Copy link
Contributor

@platon-rov platon-rov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when adding new item to the overflow layout it flickers before going to the overflow menu, the same when selecting item from overflow menu in "Forcing visibility of the items" example. it wasn't the case before.

Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now seeing some flickering when adding overflow items that wasn't there before:

Screen.Recording.2022-07-21.at.10.10.14.AM.mov

Copy link
Contributor

@platon-rov platon-rov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you refactored\changed overflow layout a lot in scope of that pr could you please fix unit tests related to it that failed?

@N1XUS N1XUS force-pushed the feat/8364-breadcrumbs-overflow-layout branch from 6371fdd to 38157f3 Compare July 22, 2022 13:06
@N1XUS N1XUS force-pushed the feat/8364-breadcrumbs-overflow-layout branch from 38157f3 to 3874f78 Compare July 22, 2022 13:07
@N1XUS
Copy link
Contributor Author

N1XUS commented Jul 22, 2022

as you refactored\changed overflow layout a lot in scope of that pr could you please fix unit tests related to it that failed?

Checked. Tests related to Overflow Layout or Breadcrumbs are not causing any errors on local run.

@N1XUS N1XUS force-pushed the feat/8364-breadcrumbs-overflow-layout branch from 45d37e8 to c7a01fa Compare July 25, 2022 11:30
@N1XUS N1XUS merged commit 0448fc6 into main Jul 25, 2022
@N1XUS N1XUS deleted the feat/8364-breadcrumbs-overflow-layout branch July 25, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: migrate breadcrumbs to use overflow layout
5 participants