Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Response Format Sample Code #538

Merged
merged 24 commits into from
Feb 17, 2025

Conversation

MatKuhr
Copy link
Member

@MatKuhr MatKuhr commented Feb 11, 2025

Context

Closes SAP/ai-sdk-js-backlog#209.

What this PR does and why it is needed

Adds sample code and E2E test for using a strict response format with OpenAI.

  • Sample Code
  • E2E Test
  • ZOD schema support
  • Docs

@deekshas8 deekshas8 changed the title Add Response Format Sample Code feat: Add Response Format Sample Code Feb 12, 2025
@deekshas8 deekshas8 marked this pull request as ready for review February 13, 2025 14:50
@deekshas8 deekshas8 requested a review from tomfrenken February 13, 2025 15:46
Copy link
Contributor

@ZhongpinWang ZhongpinWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Left some comments for improvement.

packages/orchestration/README.md Outdated Show resolved Hide resolved
packages/orchestration/README.md Outdated Show resolved Hide resolved
packages/orchestration/README.md Outdated Show resolved Hide resolved
sample-code/src/orchestration.ts Outdated Show resolved Hide resolved
sample-code/src/orchestration.ts Outdated Show resolved Hide resolved
@deekshas8 deekshas8 self-requested a review February 17, 2025 10:59
sample-code/src/index.ts Outdated Show resolved Hide resolved
Copy link
Member

@tomfrenken tomfrenken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but some adjustments would still be good 👍

packages/orchestration/README.md Outdated Show resolved Hide resolved
packages/orchestration/README.md Outdated Show resolved Hide resolved
packages/orchestration/README.md Outdated Show resolved Hide resolved
packages/orchestration/README.md Show resolved Hide resolved
Co-authored-by: Tom Frenken <54979414+tomfrenken@users.noreply.github.com>
@deekshas8 deekshas8 enabled auto-merge (squash) February 17, 2025 13:38
@deekshas8 deekshas8 merged commit 603d2c3 into main Feb 17, 2025
11 checks passed
@deekshas8 deekshas8 deleted the feat/orchestration/response-format branch February 17, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants